Commit f507b54d authored Sep 07, 2017 by Christoph Hellwig Committed by Jens Axboe Sep 25, 2017

bsg-lib: don't free job in bsg_prepare_job



The job structure is allocated as part of the request, so we should not
free it in the error path of bsg_prepare_job.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 02a48436

block/bsg-lib.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -154,7 +154,6 @@ static int bsg_prepare_job(struct device dev, struct request req)
	failjob_rls_rqst_payload:		failjob_rls_rqst_payload:
	kfree(job->request_payload.sg_list);		kfree(job->request_payload.sg_list);
	failjob_rls_job:		failjob_rls_job:
	kfree(job);
	return -ENOMEM;		return -ENOMEM;
	}		}