Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4664132 authored by Amol Lad's avatar Amol Lad Committed by Linus Torvalds
Browse files

[PATCH] ioremap balanced with iounmap for drivers/serial/ioc4_serial.c 



ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Signed-off-by: default avatarAmol Lad <amol@verismonetworks.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Brent Casavant <bcasavan@sgi.com>
Cc: Pat Gefre <pfg@sgi.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d9964d5c

drivers/serial/ioc4_serial.c

+3 −0
Original line number Diff line number Diff line
@@ -2685,6 +2685,7 @@ static int ioc4_serial_remove_one(struct ioc4_driver_data *idd) 
	if (soft) {

		free_irq(control->ic_irq, soft);

		if (soft->is_ioc4_serial_addr) {

			iounmap(soft->is_ioc4_serial_addr);

			release_region((unsigned long)

			     soft->is_ioc4_serial_addr,

				sizeof(struct ioc4_serial));
@@ -2887,6 +2888,8 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) 
out3:

	kfree(control);

out2:

	if (serial)

		iounmap(serial);

	release_region(tmp_addr1, sizeof(struct ioc4_serial));

out1: