Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4082c6f authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: bcm2835/mmal-vchiq: unlock on error in buffer_from_host() 



We should unlock before returning on this error path.

Fixes: 7b3ad5ab ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dc7ffefd

drivers/staging/media/platform/bcm2835/mmal-vchiq.c

+5 −2
Original line number Diff line number Diff line
@@ -397,8 +397,10 @@ buffer_from_host(struct vchiq_mmal_instance *instance, 


	/* get context */

	msg_context = get_msg_context(instance);

	if (msg_context == NULL)

		return -ENOMEM;

	if (!msg_context) {

		ret = -ENOMEM;

		goto unlock;

	}



	/* store bulk message context for when data arrives */

	msg_context->u.bulk.instance = instance;
@@ -454,6 +456,7 @@ buffer_from_host(struct vchiq_mmal_instance *instance, 


	vchi_service_release(instance->handle);



unlock:

	mutex_unlock(&instance->bulk_mutex);



	return ret;