Commit f3a7d118 authored Jan 15, 2018 by himanshu.madhani@cavium.com Committed by Greg Kroah-Hartman Apr 26, 2018

scsi: qla2xxx: Fix warning in qla2x00_async_iocb_timeout()




[ Upstream commit 7ac0c332f96bb9688560726f5e80c097ed8de59a ]

This patch fixes following Smatch warning:

drivers/scsi/qla2xxx/qla_init.c:130 qla2x00_async_iocb_timeout() error: we previously assumed 'fcport' could be null (see line 107)

Fixes: 5c25d451163c ("scsi: qla2xxx: Fix NULL pointer access for fcport structure")
Reported by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f3ce194c

drivers/scsi/qla2xxx/qla_init.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -115,6 +115,8 @@ qla2x00_async_iocb_timeout(void *data)

		switch (sp->type) {
		case SRB_LOGIN_CMD:
		if (!fcport)
		break;
		/* Retry as needed. */
		lio->u.logio.data[0] = MBS_COMMAND_ERROR;
		lio->u.logio.data[1] = lio->u.logio.flags & SRB_LOGIN_RETRIED ?
		@@ -128,6 +130,8 @@ qla2x00_async_iocb_timeout(void *data)
		qla24xx_handle_plogi_done_event(fcport->vha, &ea);
		break;
		case SRB_LOGOUT_CMD:
		if (!fcport)
		break;
		qlt_logo_completion_handler(fcport, QLA_FUNCTION_TIMEOUT);
		break;
		case SRB_CT_PTHRU_CMD: