Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f378dfe4 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: serial: ti_usb_3410_5052: fix up noisy printk() usage 



The driver should not be sending any printk() messages when it is
loaded, as no other USB serial driver does.  This fixes that, and also
removes the useless version number from the driver.

Cc: Johan Hovold <jhovold@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adhir Ramjiawan <adhirramjiawan0@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 93ba0f03

drivers/usb/serial/ti_usb_3410_5052.c

+1 −8
Original line number Original line Diff line number Diff line
@@ -40,7 +40,6 @@ 




/* Defines */

/* Defines */





#define TI_DRIVER_VERSION	"v0.10"

#define TI_DRIVER_AUTHOR	"Al Borchers <alborchers@steinerpoint.com>"

#define TI_DRIVER_AUTHOR	"Al Borchers <alborchers@steinerpoint.com>"

#define TI_DRIVER_DESC		"TI USB 3410/5052 Serial Driver"

#define TI_DRIVER_DESC		"TI USB 3410/5052 Serial Driver"
@@ -276,7 +275,6 @@ static struct usb_serial_driver * const serial_drivers[] = { 




MODULE_AUTHOR(TI_DRIVER_AUTHOR);

MODULE_AUTHOR(TI_DRIVER_AUTHOR);

MODULE_DESCRIPTION(TI_DRIVER_DESC);

MODULE_DESCRIPTION(TI_DRIVER_DESC);

MODULE_VERSION(TI_DRIVER_VERSION);

MODULE_LICENSE("GPL");

MODULE_LICENSE("GPL");





MODULE_FIRMWARE("ti_3410.fw");

MODULE_FIRMWARE("ti_3410.fw");
@@ -312,7 +310,6 @@ MODULE_DEVICE_TABLE(usb, ti_id_table_combined); 
static int __init ti_init(void)

static int __init ti_init(void)

{

{

	int i, j, c;

	int i, j, c;

	int ret;





	/* insert extra vendor and product ids */

	/* insert extra vendor and product ids */

	c = ARRAY_SIZE(ti_id_table_combined) - 2 * TI_EXTRA_VID_PID_COUNT - 1;

	c = ARRAY_SIZE(ti_id_table_combined) - 2 * TI_EXTRA_VID_PID_COUNT - 1;
@@ -335,11 +332,7 @@ static int __init ti_init(void) 
		ti_id_table_combined[c].match_flags = USB_DEVICE_ID_MATCH_DEVICE;

		ti_id_table_combined[c].match_flags = USB_DEVICE_ID_MATCH_DEVICE;

	}

	}





	ret = usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined);

	return usb_serial_register_drivers(serial_drivers, KBUILD_MODNAME, ti_id_table_combined);

	if (ret == 0)

		printk(KERN_INFO KBUILD_MODNAME ": " TI_DRIVER_VERSION ":"

			       TI_DRIVER_DESC "\n");

	return ret;

}

}





static void __exit ti_exit(void)

static void __exit ti_exit(void)