Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2dde159 authored by Bryan Huntsman's avatar Bryan Huntsman Committed by Kyle Yan
Browse files

scripts: checkpatch.pl: warn on invalid credentials 



@quicinc.com identities are not allowed.  Check the "From:" field in the
patch, equivalent to the author in the git commit, and the Signed-off-by
field.

Signed-off-by: default avatarBryan Huntsman <bryanh@codeaurora.org>
Signed-off-by: default avatarStepan Moskovchenko <stepanm@codeaurora.org>
[imaund@codeaurora.org: Resolved context conflicts]
Signed-off-by: default avatarIan Maund <imaund@codeaurora.org>
parent d9b3dfdf

scripts/checkpatch.pl

+9 −0
Original line number Diff line number Diff line
@@ -2335,6 +2335,10 @@ sub process { 
					     "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);

				}

			}

			if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) {

				WARN("BAD_SIGN_OFF",

				     "invalid Signed-off-by identity\n" . $line );

			}			



# Check for duplicate signatures

			my $sig_nospace = $line;
@@ -2465,6 +2469,11 @@ sub process { 
			     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);

		}



#check the patch for invalid author credentials

		if ($line =~ /^From:.*(quicinc|qualcomm)\.com/) {

			WARN("BAD_AUTHOR", "invalid author identity\n" . $line );

		}



# Check for wrappage within a valid hunk of the file

		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {

			ERROR("CORRUPTED_PATCH",