Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2ca09f3 authored by Laura Abbott's avatar Laura Abbott Committed by Russell King
Browse files

ARM: 8311/1: Don't use is_module_addr in setting page attributes



The set_memory_* functions currently only support module
addresses. The addresses are validated using is_module_addr.
That function is special though and relies on internal state
in the module subsystem to work properly. At the time of
module initialization and calling set_memory_*, it's too early
for is_module_addr to work properly so it always returns
false. Rather than be subject to the whims of the module state,
just bounds check against the module virtual address range.

Signed-off-by: default avatarLaura Abbott <lauraa@codeaurora.org>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 5c95ed47
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -49,7 +49,10 @@ static int change_memory_common(unsigned long addr, int numpages,
		WARN_ON_ONCE(1);
	}

	if (!is_module_address(start) || !is_module_address(end - 1))
	if (start < MODULES_VADDR || start >= MODULES_END)
		return -EINVAL;

	if (end < MODULES_VADDR || start >= MODULES_END)
		return -EINVAL;

	data.set_mask = set_mask;