Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2992db2 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by Linus Torvalds
Browse files

Mark res_counter_charge(_locked) with __must_check 



Ignoring their return values may result in counter underflow in the future -
when the value charged will be uncharged (or in "leaks" - when the value is
not uncharged).

This also prevents from using charging routines to decrement the
counter value (i.e. uncharge it) ;)

(Current code works OK with res_counter, however :) )

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Paul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7e9abd89

include/linux/res_counter.h

+4 −2
Original line number Diff line number Diff line
@@ -95,8 +95,10 @@ void res_counter_init(struct res_counter *counter); 
 * counter->limit _locked call expects the counter->lock to be taken

 */



int res_counter_charge_locked(struct res_counter *counter, unsigned long val);

int res_counter_charge(struct res_counter *counter, unsigned long val);

int __must_check res_counter_charge_locked(struct res_counter *counter,

		unsigned long val);

int __must_check res_counter_charge(struct res_counter *counter,

		unsigned long val);



/*

 * uncharge - tell that some portion of the resource is released