Commit f1a4876f authored Nov 19, 2018 by Felipe Balbi Committed by Greg Kroah-Hartman Dec 05, 2018

Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid"



commit 38317f5c0f2faae5110854f36edad810f841d62f upstream.

This reverts commit ffb80fc6.

Turns out that commit is wrong. Host controllers are allowed to use
Clear Feature HALT as means to sync data toggle between host and
periperal.

Cc: <stable@vger.kernel.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2b7456f4

drivers/usb/dwc3/gadget.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1511,9 +1511,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)
		unsigned transfer_in_flight;
		unsigned started;

		if (dep->flags & DWC3_EP_STALL)
		return 0;

		if (dep->number > 1)
		trb = dwc3_ep_prev_trb(dep, dep->trb_enqueue);
		else
		@@ -1535,8 +1532,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)
		else
		dep->flags \|= DWC3_EP_STALL;
		} else {
		if (!(dep->flags & DWC3_EP_STALL))
		return 0;

		ret = dwc3_send_clear_stall_ep_cmd(dep);
		if (ret)