Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f13e088c authored by Jyri Sarha's avatar Jyri Sarha
Browse files

drm/tilcdc: Fix load mode bit-field setting in tilcdc_crtc_enable() 



Set LCDC_PALETTE_LOAD_MODE bit-field with new tilcdc_write_mask()
instead of tilcdc_set(). Setting a bit-fields with tilcdc_set() is
fundamentally broken.

Signed-off-by: default avatarJyri Sarha <jsarha@ti.com>
Tested-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 0f92e898

drivers/gpu/drm/tilcdc/tilcdc_crtc.c

+3 −1
Original line number Diff line number Diff line
@@ -237,7 +237,9 @@ static void tilcdc_crtc_enable(struct drm_crtc *crtc) 
	tilcdc_crtc_enable_irqs(dev);



	tilcdc_clear(dev, LCDC_DMA_CTRL_REG, LCDC_DUAL_FRAME_BUFFER_ENABLE);

	tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_PALETTE_LOAD_MODE(DATA_ONLY));

	tilcdc_write_mask(dev, LCDC_RASTER_CTRL_REG,

			  LCDC_PALETTE_LOAD_MODE(DATA_ONLY),

			  LCDC_PALETTE_LOAD_MODE_MASK);

	tilcdc_set(dev, LCDC_RASTER_CTRL_REG, LCDC_RASTER_ENABLE);



	drm_crtc_vblank_on(crtc);