Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f057ac4e authored by Johannes Berg's avatar Johannes Berg Committed by Wey-Yi Guy
Browse files

iwlwifi: release IRQ in error path 



smatch correctly complains:
iwl-trans-pcie.c +1528 iwl_trans_pcie_start_hw(50) warn: 'trans->irq' was not released on error

Fix it.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarWey-Yi W Guy <wey-yi.w.guy@intel.com>
parent edf38334

drivers/net/wireless/iwlwifi/iwl-trans-pcie.c

+3 −1
Original line number Diff line number Diff line
@@ -1504,7 +1504,7 @@ static int iwl_trans_pcie_start_hw(struct iwl_trans *trans) 
	err = iwl_prepare_card_hw(trans);

	if (err) {

		IWL_ERR(trans, "Error while preparing HW: %d", err);

		goto error;

		goto err_free_irq;

	}



	iwl_apm_init(trans);
@@ -1522,6 +1522,8 @@ static int iwl_trans_pcie_start_hw(struct iwl_trans *trans) 


	return err;



err_free_irq:

	free_irq(trans->irq, trans);

error:

	iwl_free_isr_ict(trans);

	tasklet_kill(&trans_pcie->irq_tasklet);