Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eff596da authored by Or Gerlitz's avatar Or Gerlitz Committed by Saeed Mahameed
Browse files

net/mlx5: Return EOPNOTSUPP when failing to get steering name-space 



When we fail to retrieve a hardware steering name-space, the returned error
code should say that this operation is not supported. Align the various
places in the driver where this call is made to this convention.

Also, make sure to warn when we fail to retrieve a SW (ANCHOR) name-space.

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: default avatarMatan Barak <matanb@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 9eb78923

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

+1 −1
Original line number Diff line number Diff line
@@ -1089,7 +1089,7 @@ int mlx5e_create_flow_steering(struct mlx5e_priv *priv) 
					       MLX5_FLOW_NAMESPACE_KERNEL);



	if (!priv->fs.ns)

		return -EINVAL;

		return -EOPNOTSUPP;



	err = mlx5e_arfs_create_tables(priv);

	if (err) {

drivers/net/ethernet/mellanox/mlx5/core/eswitch.c

+3 −3
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ static int esw_create_legacy_fdb_table(struct mlx5_eswitch *esw, int nvports) 
	root_ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_FDB);

	if (!root_ns) {

		esw_warn(dev, "Failed to get FDB flow namespace\n");

		return -ENOMEM;

		return -EOPNOTSUPP;

	}



	flow_group_in = mlx5_vzalloc(inlen);
@@ -962,7 +962,7 @@ static int esw_vport_enable_egress_acl(struct mlx5_eswitch *esw, 
	root_ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_ESW_EGRESS);

	if (!root_ns) {

		esw_warn(dev, "Failed to get E-Switch egress flow namespace\n");

		return -EIO;

		return -EOPNOTSUPP;

	}



	flow_group_in = mlx5_vzalloc(inlen);
@@ -1079,7 +1079,7 @@ static int esw_vport_enable_ingress_acl(struct mlx5_eswitch *esw, 
	root_ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_ESW_INGRESS);

	if (!root_ns) {

		esw_warn(dev, "Failed to get E-Switch ingress flow namespace\n");

		return -EIO;

		return -EOPNOTSUPP;

	}



	flow_group_in = mlx5_vzalloc(inlen);

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+1 −1
Original line number Diff line number Diff line
@@ -535,7 +535,7 @@ static int esw_create_offloads_table(struct mlx5_eswitch *esw) 
	ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_OFFLOADS);

	if (!ns) {

		esw_warn(esw->dev, "Failed to get offloads flow namespace\n");

		return -ENOMEM;

		return -EOPNOTSUPP;

	}



	ft_offloads = mlx5_create_flow_table(ns, 0, dev->priv.sriov.num_vfs + 2, 0, 0);

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c

+1 −1
Original line number Diff line number Diff line
@@ -1822,7 +1822,7 @@ static int create_anchor_flow_table(struct mlx5_flow_steering *steering) 
	struct mlx5_flow_table *ft;



	ns = mlx5_get_flow_namespace(steering->dev, MLX5_FLOW_NAMESPACE_ANCHOR);

	if (!ns)

	if (WARN_ON(!ns))

		return -EINVAL;

	ft = mlx5_create_flow_table(ns, ANCHOR_PRIO, ANCHOR_SIZE, ANCHOR_LEVEL, 0);

	if (IS_ERR(ft)) {