Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef962746 authored by James Chapman's avatar James Chapman Committed by Greg Kroah-Hartman
Browse files

[PATCH] i2c: ds1337 BCD conversion fix 



Fix BCD value errors when month=9, moving the increment inside the
BIN2BCD macro.
Fix similar code for the weekday value, just for consistency.

This bug was reported by Michael Burian <dynmail1@gassner-waagen.at>.

Signed-off-by: default avatarJames Chapman <jchapman@katalix.com>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a852daa0

drivers/i2c/chips/ds1337.c

+2 −2
Original line number Diff line number Diff line
@@ -164,9 +164,9 @@ static int ds1337_set_datetime(struct i2c_client *client, struct rtc_time *dt) 
	buf[1] = BIN2BCD(dt->tm_sec);

	buf[2] = BIN2BCD(dt->tm_min);

	buf[3] = BIN2BCD(dt->tm_hour);

	buf[4] = BIN2BCD(dt->tm_wday) + 1;

	buf[4] = BIN2BCD(dt->tm_wday + 1);

	buf[5] = BIN2BCD(dt->tm_mday);

	buf[6] = BIN2BCD(dt->tm_mon) + 1;

	buf[6] = BIN2BCD(dt->tm_mon + 1);

	val = dt->tm_year;

	if (val >= 100) {

		val -= 100;