Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef68bf11 authored by Eric Biggers's avatar Eric Biggers Committed by Jaegeuk Kim
Browse files

f2fs: do not unnecessarily null-terminate encrypted symlink data 



Null-terminating the fscrypt_symlink_data on read is unnecessary because
it is not string data --- it contains binary ciphertext.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent d41065e2

fs/f2fs/namei.c

+0 −2
Original line number Diff line number Diff line
@@ -1015,7 +1015,6 @@ static const char *f2fs_encrypted_get_link(struct dentry *dentry, 
	struct fscrypt_str cstr = FSTR_INIT(NULL, 0);

	struct fscrypt_str pstr = FSTR_INIT(NULL, 0);

	struct fscrypt_symlink_data *sd;

	loff_t size = min_t(loff_t, i_size_read(inode), PAGE_SIZE - 1);

	u32 max_size = inode->i_sb->s_blocksize;

	int res;
@@ -1030,7 +1029,6 @@ static const char *f2fs_encrypted_get_link(struct dentry *dentry, 
	if (IS_ERR(cpage))

		return ERR_CAST(cpage);

	caddr = page_address(cpage);

	caddr[size] = 0;



	/* Symlink is encrypted */

	sd = (struct fscrypt_symlink_data *)caddr;