Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef330dc2 authored by Jesper Juhl's avatar Jesper Juhl Committed by Mauro Carvalho Chehab
Browse files

[media] saa7164: Remove pointless conditional and save a few bytes in saa7164_downloadfirmware() 



Hi,

release_firmware() just does nothing if passed a NULL pointer. So there's
no reason to test before the call in
saa7164-fw.c::saa7164_downloadfirmware().

Removing the pointless conditional also saves a few bytes.
before:
   text    data     bss     dec     hex filename
   7943     112    2144   10199    27d7 drivers/media/video/saa7164/saa7164-fw.o
after:
   text    data     bss     dec     hex filename
   7931     112    2136   10179    27c3 drivers/media/video/saa7164/saa7164-fw.o

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Cc: Steven Toth <stoth@kernellabs.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 10304ca6

drivers/media/video/saa7164/saa7164-fw.c

+1 −3
Original line number Diff line number Diff line
@@ -608,8 +608,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) 
	ret = 0;



out:

	if (fw)

	release_firmware(fw);



	return ret;

}