Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee370950 authored Dec 17, 2015 by Leon Romanovsky Committed by Doug Ledford Dec 24, 2015

IB/mlx4: Convert kmalloc to kmalloc_array for checkpatch



Convert kmalloc to be kmalloc_array to fix warnings below:

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64),

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               qp->rq.wrid = kmalloc(qp->rq.wqe_cnt * sizeof(u64),

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               srq->wrid = kmalloc(srq->msrq.max * sizeof(u64),

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 9afc60dc

drivers/infiniband/hw/mlx4/qp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -795,12 +795,12 @@ static int create_qp_common(struct mlx4_ib_dev dev, struct ib_pd pd,
		if (err)
		goto err_mtt;

		qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64),
		qp->sq.wrid = kmalloc_array(qp->sq.wqe_cnt, sizeof(u64),
		gfp \| __GFP_NOWARN);
		if (!qp->sq.wrid)
		qp->sq.wrid = __vmalloc(qp->sq.wqe_cnt * sizeof(u64),
		gfp, PAGE_KERNEL);
		qp->rq.wrid = kmalloc(qp->rq.wqe_cnt * sizeof(u64),
		qp->rq.wrid = kmalloc_array(qp->rq.wqe_cnt, sizeof(u64),
		gfp \| __GFP_NOWARN);
		if (!qp->rq.wrid)
		qp->rq.wrid = __vmalloc(qp->rq.wqe_cnt * sizeof(u64),

drivers/infiniband/hw/mlx4/srq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -171,7 +171,7 @@ struct ib_srq mlx4_ib_create_srq(struct ib_pd pd,
		if (err)
		goto err_mtt;

		srq->wrid = kmalloc(srq->msrq.max * sizeof(u64),
		srq->wrid = kmalloc_array(srq->msrq.max, sizeof(u64),
		GFP_KERNEL \| __GFP_NOWARN);
		if (!srq->wrid) {
		srq->wrid = __vmalloc(srq->msrq.max * sizeof(u64),