Commit eda3fc50 authored May 03, 2016 by Phil Turnbull Committed by Pablo Neira Ayuso May 05, 2016

netfilter: nfnetlink_acct: validate NFACCT_QUOTA parameter



If a quota bit is set in NFACCT_FLAGS but the NFACCT_QUOTA parameter is
missing then a NULL pointer dereference is triggered. CAP_NET_ADMIN is
required to trigger the bug.

Signed-off-by: Phil Turnbull <phil.turnbull@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent cec5913c

net/netfilter/nfnetlink_acct.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -96,6 +96,8 @@ static int nfnl_acct_new(struct net net, struct sock nfnl,
		return -EINVAL;
		if (flags & NFACCT_F_OVERQUOTA)
		return -EINVAL;
		if ((flags & NFACCT_F_QUOTA) && !tb[NFACCT_QUOTA])
		return -EINVAL;

		size += sizeof(u64);
		}