Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eca496d8 authored by Maxime Ripard's avatar Maxime Ripard Committed by Greg Kroah-Hartman
Browse files

ASoC: sun8i-codec: Fix left and right channels inversion 



commit 18c1bf35c1c09bca05cf70bc984a4764e0b0372b upstream.

Since its introduction, the codec had an inversion of the left and right
channels. It turned out to be pretty simple as it appears that the codec
doesn't have the same polarity on the LRCK signal than the I2S block.

Fix this by inverting our bit value for the LRCK inversion.

Fixes: 36c68493 ("ASoC: Add sun8i digital audio codec")
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0bc4abfb

sound/soc/sunxi/sun8i-codec.c

+1 −1
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ static int sun8i_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) 
			   value << SUN8I_AIF1CLK_CTRL_AIF1_BCLK_INV);

	regmap_update_bits(scodec->regmap, SUN8I_AIF1CLK_CTRL,

			   BIT(SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV),

			   value << SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV);

			   !value << SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV);



	/* DAI format */

	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {