Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec44fd42 authored by Axel Lin's avatar Axel Lin Committed by Linus Torvalds
Browse files

drivers/leds/leds-lm3530.c: fix setting pltfm->als_vmax 



In current code, pltfm->als_vmin is set to LM3530_ALS_WINDOW_mV and
pltfm->als_vmax is 0.  This does not make sense.  I think what we want
here is setting pltfm->als_vmax to LM3530_ALS_WINDOW_mV.

Both als_vmin and als_vmax local variables will be set to
pltfm->als_vmin and pltfm->als_vmax by a few lines latter.  Thus also
remove a redundant assignment for als_vmin and als_vmax in this patch.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Cc: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
Acked-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Tested-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dc908600

drivers/leds/leds-lm3530.c

+2 −2
Original line number Diff line number Diff line
@@ -164,8 +164,8 @@ static int lm3530_init_registers(struct lm3530_data *drvdata) 


	if (drvdata->mode == LM3530_BL_MODE_ALS) {

		if (pltfm->als_vmax == 0) {

			pltfm->als_vmin = als_vmin = 0;

			pltfm->als_vmin = als_vmax = LM3530_ALS_WINDOW_mV;

			pltfm->als_vmin = 0;

			pltfm->als_vmax = LM3530_ALS_WINDOW_mV;

		}



		als_vmin = pltfm->als_vmin;