Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eafea739 authored by David Ahern's avatar David Ahern Committed by David S. Miller
Browse files

net: ipv4: remove disable of bottom half in inet_rtm_getroute 



Nothing about the route lookup requires bottom half to be disabled.
Remove the local_bh_disable ... local_bh_enable around ip_route_input.
This appears to be a vestige of days gone by as it has been there
since the beginning of git time.

Signed-off-by: default avatarDavid Ahern <dsa@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6b0c06e0

net/ipv4/route.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -2631,9 +2631,7 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh) 
		skb->protocol	= htons(ETH_P_IP);

		skb->protocol	= htons(ETH_P_IP);

		skb->dev	= dev;

		skb->dev	= dev;

		skb->mark	= mark;

		skb->mark	= mark;

		local_bh_disable();

		err = ip_route_input(skb, dst, src, rtm->rtm_tos, dev);

		err = ip_route_input(skb, dst, src, rtm->rtm_tos, dev);

		local_bh_enable();





		rt = skb_rtable(skb);

		rt = skb_rtable(skb);

		if (err == 0 && rt->dst.error)

		if (err == 0 && rt->dst.error)