Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e96da398 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: serial: mct_u232: clean up urb->status usage 



This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.


Cc: <linux-usb-devel@lists.sourceforge.net>
Cc: Wolfgang Grandegger <wolfgang@ces.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6fcdcf04

drivers/usb/serial/mct_u232.c

+10 −7
Original line number Diff line number Diff line
@@ -516,10 +516,11 @@ static void mct_u232_read_int_callback (struct urb *urb) 
	struct usb_serial *serial = port->serial;

	struct tty_struct *tty;

	unsigned char *data = urb->transfer_buffer;

	int status;

	int retval;

	int status = urb->status;

	unsigned long flags;



	switch (urb->status) {

	switch (status) {

	case 0:

		/* success */

		break;
@@ -527,10 +528,12 @@ static void mct_u232_read_int_callback (struct urb *urb) 
	case -ENOENT:

	case -ESHUTDOWN:

		/* this urb is terminated, clean up */

		dbg("%s - urb shutting down with status: %d", __FUNCTION__, urb->status);

		dbg("%s - urb shutting down with status: %d",

		    __FUNCTION__, status);

		return;

	default:

		dbg("%s - nonzero urb status received: %d", __FUNCTION__, urb->status);

		dbg("%s - nonzero urb status received: %d",

		    __FUNCTION__, status);

		goto exit;

	}
@@ -594,10 +597,10 @@ static void mct_u232_read_int_callback (struct urb *urb) 
#endif

	spin_unlock_irqrestore(&priv->lock, flags);

exit:

	status = usb_submit_urb (urb, GFP_ATOMIC);

	if (status)

	retval = usb_submit_urb (urb, GFP_ATOMIC);

	if (retval)

		err ("%s - usb_submit_urb failed with result %d",

		     __FUNCTION__, status);

		     __FUNCTION__, retval);

} /* mct_u232_read_int_callback */



static void mct_u232_set_termios (struct usb_serial_port *port,