Commit e8bc3c99 authored Dec 08, 2015 by Dan Carpenter Committed by Mark Brown Dec 16, 2015

ASoC: Intel: Skylake: pointer math issue



"data" is a u32 pointer so this copies the information to wrong place
entirely.

Fixes: 140adfba ('ASoC: Intel: Skylake: Add tlv byte kcontrols')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Tested-by: Dharageswari R <dharageswari.r@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent db4e5613

sound/soc/intel/skylake/skl-topology.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -919,9 +919,9 @@ static int skl_tplg_tlv_control_get(struct snd_kcontrol *kcontrol,
		if (bc->params) {
		if (copy_to_user(data, &bc->param_id, sizeof(u32)))
		return -EFAULT;
		if (copy_to_user(data + sizeof(u32), &size, sizeof(u32)))
		if (copy_to_user(data + 1, &size, sizeof(u32)))
		return -EFAULT;
		if (copy_to_user(data + 2 * sizeof(u32), bc->params, size))
		if (copy_to_user(data + 2, bc->params, size))
		return -EFAULT;
		}