Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e87c077f authored by Olof Johansson's avatar Olof Johansson
Browse files

Merge tag 'v4.9-next-soc' of https://github.com/mbgg/linux-mediatek into next/drivers 

- prepare mtk-scpsys to for multi soc support
- add support for mt2701 to mtk-scpsys

* tag 'v4.9-next-soc' of https://github.com/mbgg/linux-mediatek

:
  soc: mediatek: Add MT2701 scpsys driver
  soc: mediatek: Refine scpsys to support multiple platform

Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
parents b9bccf35 112ef188

drivers/soc/mediatek/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ config MTK_PMIC_WRAP 
config MTK_SCPSYS

	bool "MediaTek SCPSYS Support"

	depends on ARCH_MEDIATEK || COMPILE_TEST

	default ARM64 && ARCH_MEDIATEK

	default ARCH_MEDIATEK

	select REGMAP

	select MTK_INFRACFG

	select PM_GENERIC_DOMAINS if PM

drivers/soc/mediatek/mtk-scpsys.c

+326 −139
Original line number Diff line number Diff line
@@ -11,17 +11,16 @@ 
 * GNU General Public License for more details.

 */

#include <linux/clk.h>

#include <linux/delay.h>

#include <linux/init.h>

#include <linux/io.h>

#include <linux/kernel.h>

#include <linux/mfd/syscon.h>

#include <linux/init.h>

#include <linux/of_device.h>

#include <linux/platform_device.h>

#include <linux/pm_domain.h>

#include <linux/regmap.h>

#include <linux/soc/mediatek/infracfg.h>

#include <linux/regulator/consumer.h>

#include <linux/soc/mediatek/infracfg.h>



#include <dt-bindings/power/mt2701-power.h>

#include <dt-bindings/power/mt8173-power.h>



#define SPM_VDE_PWR_CON			0x0210
@@ -29,11 +28,17 @@ 
#define SPM_VEN_PWR_CON			0x0230

#define SPM_ISP_PWR_CON			0x0238

#define SPM_DIS_PWR_CON			0x023c

#define SPM_CONN_PWR_CON		0x0280

#define SPM_VEN2_PWR_CON		0x0298

#define SPM_AUDIO_PWR_CON		0x029c

#define SPM_AUDIO_PWR_CON		0x029c	/* MT8173 */

#define SPM_BDP_PWR_CON			0x029c	/* MT2701 */

#define SPM_ETH_PWR_CON			0x02a0

#define SPM_HIF_PWR_CON			0x02a4

#define SPM_IFR_MSC_PWR_CON		0x02a8

#define SPM_MFG_2D_PWR_CON		0x02c0

#define SPM_MFG_ASYNC_PWR_CON		0x02c4

#define SPM_USB_PWR_CON			0x02cc



#define SPM_PWR_STATUS			0x060c

#define SPM_PWR_STATUS_2ND		0x0610
@@ -43,10 +48,15 @@ 
#define PWR_ON_2ND_BIT			BIT(3)

#define PWR_CLK_DIS_BIT			BIT(4)



#define PWR_STATUS_CONN			BIT(1)

#define PWR_STATUS_DISP			BIT(3)

#define PWR_STATUS_MFG			BIT(4)

#define PWR_STATUS_ISP			BIT(5)

#define PWR_STATUS_VDEC			BIT(7)

#define PWR_STATUS_BDP			BIT(14)

#define PWR_STATUS_ETH			BIT(15)

#define PWR_STATUS_HIF			BIT(16)

#define PWR_STATUS_IFR_MSC		BIT(17)

#define PWR_STATUS_VENC_LT		BIT(20)

#define PWR_STATUS_VENC			BIT(21)

#define PWR_STATUS_MFG_2D		BIT(22)
@@ -55,12 +65,23 @@ 
#define PWR_STATUS_USB			BIT(25)



enum clk_id {

	MT8173_CLK_NONE,

	MT8173_CLK_MM,

	MT8173_CLK_MFG,

	MT8173_CLK_VENC,

	MT8173_CLK_VENC_LT,

	MT8173_CLK_MAX,

	CLK_NONE,

	CLK_MM,

	CLK_MFG,

	CLK_VENC,

	CLK_VENC_LT,

	CLK_ETHIF,

	CLK_MAX,

};



static const char * const clk_names[] = {

	NULL,

	"mm",

	"mfg",

	"venc",

	"venc_lt",

	"ethif",

	NULL,

};



#define MAX_CLKS	2
@@ -76,98 +97,6 @@ struct scp_domain_data { 
	bool active_wakeup;

};



static const struct scp_domain_data scp_domain_data[] = {

	[MT8173_POWER_DOMAIN_VDEC] = {

		.name = "vdec",

		.sta_mask = PWR_STATUS_VDEC,

		.ctl_offs = SPM_VDE_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {MT8173_CLK_MM},

	},

	[MT8173_POWER_DOMAIN_VENC] = {

		.name = "venc",

		.sta_mask = PWR_STATUS_VENC,

		.ctl_offs = SPM_VEN_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {MT8173_CLK_MM, MT8173_CLK_VENC},

	},

	[MT8173_POWER_DOMAIN_ISP] = {

		.name = "isp",

		.sta_mask = PWR_STATUS_ISP,

		.ctl_offs = SPM_ISP_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(13, 12),

		.clk_id = {MT8173_CLK_MM},

	},

	[MT8173_POWER_DOMAIN_MM] = {

		.name = "mm",

		.sta_mask = PWR_STATUS_DISP,

		.ctl_offs = SPM_DIS_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {MT8173_CLK_MM},

		.bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MM_M0 |

			MT8173_TOP_AXI_PROT_EN_MM_M1,

	},

	[MT8173_POWER_DOMAIN_VENC_LT] = {

		.name = "venc_lt",

		.sta_mask = PWR_STATUS_VENC_LT,

		.ctl_offs = SPM_VEN2_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {MT8173_CLK_MM, MT8173_CLK_VENC_LT},

	},

	[MT8173_POWER_DOMAIN_AUDIO] = {

		.name = "audio",

		.sta_mask = PWR_STATUS_AUDIO,

		.ctl_offs = SPM_AUDIO_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {MT8173_CLK_NONE},

	},

	[MT8173_POWER_DOMAIN_USB] = {

		.name = "usb",

		.sta_mask = PWR_STATUS_USB,

		.ctl_offs = SPM_USB_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {MT8173_CLK_NONE},

		.active_wakeup = true,

	},

	[MT8173_POWER_DOMAIN_MFG_ASYNC] = {

		.name = "mfg_async",

		.sta_mask = PWR_STATUS_MFG_ASYNC,

		.ctl_offs = SPM_MFG_ASYNC_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = 0,

		.clk_id = {MT8173_CLK_MFG},

	},

	[MT8173_POWER_DOMAIN_MFG_2D] = {

		.name = "mfg_2d",

		.sta_mask = PWR_STATUS_MFG_2D,

		.ctl_offs = SPM_MFG_2D_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(13, 12),

		.clk_id = {MT8173_CLK_NONE},

	},

	[MT8173_POWER_DOMAIN_MFG] = {

		.name = "mfg",

		.sta_mask = PWR_STATUS_MFG,

		.ctl_offs = SPM_MFG_PWR_CON,

		.sram_pdn_bits = GENMASK(13, 8),

		.sram_pdn_ack_bits = GENMASK(21, 16),

		.clk_id = {MT8173_CLK_NONE},

		.bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MFG_S |

			MT8173_TOP_AXI_PROT_EN_MFG_M0 |

			MT8173_TOP_AXI_PROT_EN_MFG_M1 |

			MT8173_TOP_AXI_PROT_EN_MFG_SNOOP_OUT,

	},

};



#define NUM_DOMAINS	ARRAY_SIZE(scp_domain_data)



struct scp;



struct scp_domain {
@@ -179,7 +108,7 @@ struct scp_domain { 
};



struct scp {

	struct scp_domain domains[NUM_DOMAINS];

	struct scp_domain *domains;

	struct genpd_onecell_data pd_data;

	struct device *dev;

	void __iomem *base;
@@ -408,57 +337,55 @@ static bool scpsys_active_wakeup(struct device *dev) 
	return scpd->data->active_wakeup;

}



static int scpsys_probe(struct platform_device *pdev)

static void init_clks(struct platform_device *pdev, struct clk **clk)

{

	int i;



	for (i = CLK_NONE + 1; i < CLK_MAX; i++)

		clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);

}



static struct scp *init_scp(struct platform_device *pdev,

			const struct scp_domain_data *scp_domain_data, int num)

{

	struct genpd_onecell_data *pd_data;

	struct resource *res;

	int i, j, ret;

	int i, j;

	struct scp *scp;

	struct clk *clk[MT8173_CLK_MAX];

	struct clk *clk[CLK_MAX];



	scp = devm_kzalloc(&pdev->dev, sizeof(*scp), GFP_KERNEL);

	if (!scp)

		return -ENOMEM;

		return ERR_PTR(-ENOMEM);



	scp->dev = &pdev->dev;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	scp->base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(scp->base))

		return PTR_ERR(scp->base);

		return ERR_CAST(scp->base);



	scp->domains = devm_kzalloc(&pdev->dev,

				sizeof(*scp->domains) * num, GFP_KERNEL);

	if (!scp->domains)

		return ERR_PTR(-ENOMEM);



	pd_data = &scp->pd_data;



	pd_data->domains = devm_kzalloc(&pdev->dev,

			sizeof(*pd_data->domains) * NUM_DOMAINS, GFP_KERNEL);

			sizeof(*pd_data->domains) * num, GFP_KERNEL);

	if (!pd_data->domains)

		return -ENOMEM;



	clk[MT8173_CLK_MM] = devm_clk_get(&pdev->dev, "mm");

	if (IS_ERR(clk[MT8173_CLK_MM]))

		return PTR_ERR(clk[MT8173_CLK_MM]);



	clk[MT8173_CLK_MFG] = devm_clk_get(&pdev->dev, "mfg");

	if (IS_ERR(clk[MT8173_CLK_MFG]))

		return PTR_ERR(clk[MT8173_CLK_MFG]);



	clk[MT8173_CLK_VENC] = devm_clk_get(&pdev->dev, "venc");

	if (IS_ERR(clk[MT8173_CLK_VENC]))

		return PTR_ERR(clk[MT8173_CLK_VENC]);



	clk[MT8173_CLK_VENC_LT] = devm_clk_get(&pdev->dev, "venc_lt");

	if (IS_ERR(clk[MT8173_CLK_VENC_LT]))

		return PTR_ERR(clk[MT8173_CLK_VENC_LT]);

		return ERR_PTR(-ENOMEM);



	scp->infracfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,

			"infracfg");

	if (IS_ERR(scp->infracfg)) {

		dev_err(&pdev->dev, "Cannot find infracfg controller: %ld\n",

				PTR_ERR(scp->infracfg));

		return PTR_ERR(scp->infracfg);

		return ERR_CAST(scp->infracfg);

	}



	for (i = 0; i < NUM_DOMAINS; i++) {

	for (i = 0; i < num; i++) {

		struct scp_domain *scpd = &scp->domains[i];

		const struct scp_domain_data *data = &scp_domain_data[i];
@@ -467,13 +394,15 @@ static int scpsys_probe(struct platform_device *pdev) 
			if (PTR_ERR(scpd->supply) == -ENODEV)

				scpd->supply = NULL;

			else

				return PTR_ERR(scpd->supply);

				return ERR_CAST(scpd->supply);

		}

	}



	pd_data->num_domains = NUM_DOMAINS;

	pd_data->num_domains = num;



	init_clks(pdev, clk);



	for (i = 0; i < NUM_DOMAINS; i++) {

	for (i = 0; i < num; i++) {

		struct scp_domain *scpd = &scp->domains[i];

		struct generic_pm_domain *genpd = &scpd->genpd;

		const struct scp_domain_data *data = &scp_domain_data[i];
@@ -482,13 +411,37 @@ static int scpsys_probe(struct platform_device *pdev) 
		scpd->scp = scp;



		scpd->data = data;

		for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++)

			scpd->clk[j] = clk[data->clk_id[j]];



		for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) {

			struct clk *c = clk[data->clk_id[j]];



			if (IS_ERR(c)) {

				dev_err(&pdev->dev, "%s: clk unavailable\n",

					data->name);

				return ERR_CAST(c);

			}



			scpd->clk[j] = c;

		}



		genpd->name = data->name;

		genpd->power_off = scpsys_power_off;

		genpd->power_on = scpsys_power_on;

		genpd->dev_ops.active_wakeup = scpsys_active_wakeup;

	}



	return scp;

}



static void mtk_register_power_domains(struct platform_device *pdev,

				struct scp *scp, int num)

{

	struct genpd_onecell_data *pd_data;

	int i, ret;



	for (i = 0; i < num; i++) {

		struct scp_domain *scpd = &scp->domains[i];

		struct generic_pm_domain *genpd = &scpd->genpd;



		/*

		 * Initially turn on all domains to make the domains usable
@@ -507,6 +460,222 @@ static int scpsys_probe(struct platform_device *pdev) 
	 * valid.

	 */



	pd_data = &scp->pd_data;



	ret = of_genpd_add_provider_onecell(pdev->dev.of_node, pd_data);

	if (ret)

		dev_err(&pdev->dev, "Failed to add OF provider: %d\n", ret);

}



/*

 * MT2701 power domain support

 */



static const struct scp_domain_data scp_domain_data_mt2701[] = {

	[MT2701_POWER_DOMAIN_CONN] = {

		.name = "conn",

		.sta_mask = PWR_STATUS_CONN,

		.ctl_offs = SPM_CONN_PWR_CON,

		.bus_prot_mask = 0x0104,

		.clk_id = {CLK_NONE},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_DISP] = {

		.name = "disp",

		.sta_mask = PWR_STATUS_DISP,

		.ctl_offs = SPM_DIS_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.clk_id = {CLK_MM},

		.bus_prot_mask = 0x0002,

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_MFG] = {

		.name = "mfg",

		.sta_mask = PWR_STATUS_MFG,

		.ctl_offs = SPM_MFG_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {CLK_MFG},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_VDEC] = {

		.name = "vdec",

		.sta_mask = PWR_STATUS_VDEC,

		.ctl_offs = SPM_VDE_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {CLK_MM},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_ISP] = {

		.name = "isp",

		.sta_mask = PWR_STATUS_ISP,

		.ctl_offs = SPM_ISP_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(13, 12),

		.clk_id = {CLK_MM},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_BDP] = {

		.name = "bdp",

		.sta_mask = PWR_STATUS_BDP,

		.ctl_offs = SPM_BDP_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.clk_id = {CLK_NONE},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_ETH] = {

		.name = "eth",

		.sta_mask = PWR_STATUS_ETH,

		.ctl_offs = SPM_ETH_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_ETHIF},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_HIF] = {

		.name = "hif",

		.sta_mask = PWR_STATUS_HIF,

		.ctl_offs = SPM_HIF_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_ETHIF},

		.active_wakeup = true,

	},

	[MT2701_POWER_DOMAIN_IFR_MSC] = {

		.name = "ifr_msc",

		.sta_mask = PWR_STATUS_IFR_MSC,

		.ctl_offs = SPM_IFR_MSC_PWR_CON,

		.clk_id = {CLK_NONE},

		.active_wakeup = true,

	},

};



#define NUM_DOMAINS_MT2701	ARRAY_SIZE(scp_domain_data_mt2701)



static int __init scpsys_probe_mt2701(struct platform_device *pdev)

{

	struct scp *scp;



	scp = init_scp(pdev, scp_domain_data_mt2701, NUM_DOMAINS_MT2701);

	if (IS_ERR(scp))

		return PTR_ERR(scp);



	mtk_register_power_domains(pdev, scp, NUM_DOMAINS_MT2701);



	return 0;

}



/*

 * MT8173 power domain support

 */



static const struct scp_domain_data scp_domain_data_mt8173[] = {

	[MT8173_POWER_DOMAIN_VDEC] = {

		.name = "vdec",

		.sta_mask = PWR_STATUS_VDEC,

		.ctl_offs = SPM_VDE_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {CLK_MM},

	},

	[MT8173_POWER_DOMAIN_VENC] = {

		.name = "venc",

		.sta_mask = PWR_STATUS_VENC,

		.ctl_offs = SPM_VEN_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_MM, CLK_VENC},

	},

	[MT8173_POWER_DOMAIN_ISP] = {

		.name = "isp",

		.sta_mask = PWR_STATUS_ISP,

		.ctl_offs = SPM_ISP_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(13, 12),

		.clk_id = {CLK_MM},

	},

	[MT8173_POWER_DOMAIN_MM] = {

		.name = "mm",

		.sta_mask = PWR_STATUS_DISP,

		.ctl_offs = SPM_DIS_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(12, 12),

		.clk_id = {CLK_MM},

		.bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MM_M0 |

			MT8173_TOP_AXI_PROT_EN_MM_M1,

	},

	[MT8173_POWER_DOMAIN_VENC_LT] = {

		.name = "venc_lt",

		.sta_mask = PWR_STATUS_VENC_LT,

		.ctl_offs = SPM_VEN2_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_MM, CLK_VENC_LT},

	},

	[MT8173_POWER_DOMAIN_AUDIO] = {

		.name = "audio",

		.sta_mask = PWR_STATUS_AUDIO,

		.ctl_offs = SPM_AUDIO_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_NONE},

	},

	[MT8173_POWER_DOMAIN_USB] = {

		.name = "usb",

		.sta_mask = PWR_STATUS_USB,

		.ctl_offs = SPM_USB_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(15, 12),

		.clk_id = {CLK_NONE},

		.active_wakeup = true,

	},

	[MT8173_POWER_DOMAIN_MFG_ASYNC] = {

		.name = "mfg_async",

		.sta_mask = PWR_STATUS_MFG_ASYNC,

		.ctl_offs = SPM_MFG_ASYNC_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = 0,

		.clk_id = {CLK_MFG},

	},

	[MT8173_POWER_DOMAIN_MFG_2D] = {

		.name = "mfg_2d",

		.sta_mask = PWR_STATUS_MFG_2D,

		.ctl_offs = SPM_MFG_2D_PWR_CON,

		.sram_pdn_bits = GENMASK(11, 8),

		.sram_pdn_ack_bits = GENMASK(13, 12),

		.clk_id = {CLK_NONE},

	},

	[MT8173_POWER_DOMAIN_MFG] = {

		.name = "mfg",

		.sta_mask = PWR_STATUS_MFG,

		.ctl_offs = SPM_MFG_PWR_CON,

		.sram_pdn_bits = GENMASK(13, 8),

		.sram_pdn_ack_bits = GENMASK(21, 16),

		.clk_id = {CLK_NONE},

		.bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MFG_S |

			MT8173_TOP_AXI_PROT_EN_MFG_M0 |

			MT8173_TOP_AXI_PROT_EN_MFG_M1 |

			MT8173_TOP_AXI_PROT_EN_MFG_SNOOP_OUT,

	},

};



#define NUM_DOMAINS_MT8173	ARRAY_SIZE(scp_domain_data_mt8173)



static int __init scpsys_probe_mt8173(struct platform_device *pdev)

{

	struct scp *scp;

	struct genpd_onecell_data *pd_data;

	int ret;



	scp = init_scp(pdev, scp_domain_data_mt8173, NUM_DOMAINS_MT8173);

	if (IS_ERR(scp))

		return PTR_ERR(scp);



	mtk_register_power_domains(pdev, scp, NUM_DOMAINS_MT8173);



	pd_data = &scp->pd_data;



	ret = pm_genpd_add_subdomain(pd_data->domains[MT8173_POWER_DOMAIN_MFG_ASYNC],

		pd_data->domains[MT8173_POWER_DOMAIN_MFG_2D]);

	if (ret && IS_ENABLED(CONFIG_PM))
@@ -517,21 +686,39 @@ static int scpsys_probe(struct platform_device *pdev) 
	if (ret && IS_ENABLED(CONFIG_PM))

		dev_err(&pdev->dev, "Failed to add subdomain: %d\n", ret);



	ret = of_genpd_add_provider_onecell(pdev->dev.of_node, pd_data);

	if (ret)

		dev_err(&pdev->dev, "Failed to add OF provider: %d\n", ret);



	return 0;

}



/*

 * scpsys driver init

 */



static const struct of_device_id of_scpsys_match_tbl[] = {

	{

		.compatible = "mediatek,mt2701-scpsys",

		.data = scpsys_probe_mt2701,

	}, {

		.compatible = "mediatek,mt8173-scpsys",

		.data = scpsys_probe_mt8173,

	}, {

		/* sentinel */

	}

};



static int scpsys_probe(struct platform_device *pdev)

{

	int (*probe)(struct platform_device *);

	const struct of_device_id *of_id;



	of_id = of_match_node(of_scpsys_match_tbl, pdev->dev.of_node);

	if (!of_id || !of_id->data)

		return -EINVAL;



	probe = of_id->data;



	return probe(pdev);

}



static struct platform_driver scpsys_drv = {

	.probe = scpsys_probe,

	.driver = {