Commit e7f2b054 authored Mar 06, 2018 by Arvind Yadav Committed by Greg Kroah-Hartman May 30, 2018

xen: xenbus: use put_device() instead of kfree()



[ Upstream commit 351b2bccede1cb673ec7957b35ea997ea24c8884 ]

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9238d1fa

drivers/xen/xenbus/xenbus_probe.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -466,8 +466,11 @@ int xenbus_probe_node(struct xen_bus_type *bus,

		/* Register with generic device framework. */
		err = device_register(&xendev->dev);
		if (err)
		if (err) {
		put_device(&xendev->dev);
		xendev = NULL;
		goto fail;
		}

		return 0;
		fail: