Commit e609ccef authored Feb 24, 2017 by Alexander Shishkin

intel_th: Don't leak module refcount on failure to activate



Output 'activation' may fail for the reasons of the output driver,
for example, if msc's buffer is not allocated. We forget, however,
to drop the module reference in this case. So each attempt at
activation in this case leaks a reference, preventing the module
from ever unloading.

This patch adds the missing module_put() in the activation error
path.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: stable@vger.kernel.org # v4.8+

parent 4495c08e

drivers/hwtracing/intel_th/core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -221,8 +221,10 @@ static int intel_th_output_activate(struct intel_th_device *thdev)
		else
		intel_th_trace_enable(thdev);

		if (ret)
		if (ret) {
		pm_runtime_put(&thdev->dev);
		module_put(thdrv->driver.owner);
		}

		return ret;
		}