Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5d32205 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

i40e/i40evf: replace for memcpy with single memcpy call in ethtool 



memcpy replaced with single memcpy call in ethtool.

Change-ID: I3f5bef6bcc593412c56592c6459784db41575a0a
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 435c084a

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+8 −16
Original line number Diff line number Diff line
@@ -1536,10 +1536,8 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, 


	switch (stringset) {

	case ETH_SS_TEST:

		for (i = 0; i < I40E_TEST_LEN; i++) {

			memcpy(data, i40e_gstrings_test[i], ETH_GSTRING_LEN);

			data += ETH_GSTRING_LEN;

		}

		memcpy(data, i40e_gstrings_test,

		       I40E_TEST_LEN * ETH_GSTRING_LEN);

		break;

	case ETH_SS_STATS:

		for (i = 0; i < I40E_NETDEV_STATS_LEN; i++) {
@@ -1623,18 +1621,12 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset, 
		/* BUG_ON(p - data != I40E_STATS_LEN * ETH_GSTRING_LEN); */

		break;

	case ETH_SS_PRIV_FLAGS:

		for (i = 0; i < I40E_PRIV_FLAGS_STR_LEN; i++) {

			memcpy(data, i40e_priv_flags_strings[i],

			       ETH_GSTRING_LEN);

			data += ETH_GSTRING_LEN;

		}

		if (pf->hw.pf_id == 0) {

			for (i = 0; i < I40E_GL_PRIV_FLAGS_STR_LEN; i++) {

				memcpy(data, i40e_gl_priv_flags_strings[i],

				       ETH_GSTRING_LEN);

				data += ETH_GSTRING_LEN;

			}

		}

		memcpy(data, i40e_priv_flags_strings,

		       I40E_PRIV_FLAGS_STR_LEN * ETH_GSTRING_LEN);

		data += I40E_PRIV_FLAGS_STR_LEN * ETH_GSTRING_LEN;

		if (pf->hw.pf_id == 0)

			memcpy(data, i40e_gl_priv_flags_strings,

			       I40E_GL_PRIV_FLAGS_STR_LEN * ETH_GSTRING_LEN);

		break;

	default:

		break;