Commit e546b1ef authored Sep 21, 2016 by Wei Yongjun Committed by Mauro Carvalho Chehab Oct 24, 2016

[media] cx88: fix error return code in cx8802_dvb_probe()



Fix to return error code -ENODEV from the error handling case
instead of 0(err maybe overwrited to 0 in the for loop), as
done elsewhere in this function.

[mchehab@s-opensource.com: remove a now uneeded set for err = -ENODEV]

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 017f4fb7

drivers/media/pci/cx88/cx88-dvb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1769,7 +1769,6 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv)
		if (err)
		goto fail_core;

		err = -ENODEV;
		for (i = 1; i <= core->board.num_frontends; i++) {
		struct vb2_queue *q;

		@@ -1777,6 +1776,7 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv)
		if (fe == NULL) {
		printk(KERN_ERR "%s() failed to get frontend(%d)\n",
		__func__, i);
		err = -ENODEV;
		goto fail_probe;
		}
		q = &fe->dvb.dvbq;