Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4ec8cc8 authored by Kangjie Lu's avatar Kangjie Lu Committed by Takashi Iwai
Browse files

ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt 



The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9a47e9cf

sound/core/timer.c

+1 −0
Original line number Diff line number Diff line
@@ -1266,6 +1266,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri, 
	}

	if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&

	    tu->last_resolution != resolution) {

		memset(&r1, 0, sizeof(r1));

		r1.event = SNDRV_TIMER_EVENT_RESOLUTION;

		r1.tstamp = tstamp;

		r1.val = resolution;