Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e426115e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

misc: mic/scif: fix error code in scif_create_remote_lookup() 



We should be returning -ENOMEM here instead of success.

Fixes: ba612aa8 ('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSudeep Dutt <sudeep.dutt@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ff65212c

drivers/misc/mic/scif/scif_rma.c

+6 −2
Original line number Diff line number Diff line
@@ -386,16 +386,20 @@ static int scif_create_remote_lookup(struct scif_dev *remote_dev, 
				    remote_dev, window->nr_lookup *

				    sizeof(*window->dma_addr_lookup.lookup),

				    GFP_KERNEL | __GFP_ZERO);

	if (!window->dma_addr_lookup.lookup)

	if (!window->dma_addr_lookup.lookup) {

		err = -ENOMEM;

		goto error_window;

	}



	window->num_pages_lookup.lookup =

		scif_alloc_coherent(&window->num_pages_lookup.offset,

				    remote_dev, window->nr_lookup *

				    sizeof(*window->num_pages_lookup.lookup),

				    GFP_KERNEL | __GFP_ZERO);

	if (!window->num_pages_lookup.lookup)

	if (!window->num_pages_lookup.lookup) {

		err = -ENOMEM;

		goto error_window;

	}



	vmalloc_dma_phys = is_vmalloc_addr(&window->dma_addr[0]);

	vmalloc_num_pages = is_vmalloc_addr(&window->num_pages[0]);