Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3c4a28b authored by Xiubo Li's avatar Xiubo Li Committed by Mark Brown
Browse files

ASoC: simple-card: Fix bug of wrong decrement DT node's refcount 



DAI links's cpu_of_node's and codec_of_node's refcounts shouldn't
be decremented immediately at the end of the probe() fucntion.
Because we will still use them before the audio card is removed.

Signed-off-by: default avatarXiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7d1311b9

sound/soc/generic/simple-card.c

+8 −0
Original line number Diff line number Diff line
@@ -481,12 +481,19 @@ static int asoc_simple_card_probe(struct platform_device *pdev) 
	snd_soc_card_set_drvdata(&priv->snd_card, priv);



	ret = devm_snd_soc_register_card(&pdev->dev, &priv->snd_card);

	if (ret >= 0)

		return ret;



err:

	asoc_simple_card_unref(pdev);

	return ret;

}



static int asoc_simple_card_remove(struct platform_device *pdev)

{

	return asoc_simple_card_unref(pdev);

}



static const struct of_device_id asoc_simple_of_match[] = {

	{ .compatible = "simple-audio-card", },

	{},
@@ -500,6 +507,7 @@ static struct platform_driver asoc_simple_card = { 
		.of_match_table = asoc_simple_of_match,

	},

	.probe = asoc_simple_card_probe,

	.remove = asoc_simple_card_remove,

};



module_platform_driver(asoc_simple_card);