Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3a68e30 authored by Dave Hansen's avatar Dave Hansen Committed by Linus Torvalds
Browse files

ext3: remove extra IS_RDONLY() check 



ext3_change_inode_journal_flag() is only called from one location:
ext3_ioctl(EXT3_IOC_SETFLAGS).  That ioctl case already has a IS_RDONLY()
call in it so this one is superfluous.

Signed-off-by: default avatarDave Hansen <haveblue@us.ibm.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6b86e854

fs/ext3/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -3195,7 +3195,7 @@ int ext3_change_inode_journal_flag(struct inode *inode, int val) 
	 */



	journal = EXT3_JOURNAL(inode);

	if (is_journal_aborted(journal) || IS_RDONLY(inode))

	if (is_journal_aborted(journal))

		return -EROFS;



	journal_lock_updates(journal);