Commit e37720e2 authored Jul 14, 2017 by Linus Torvalds

linux-pm

Pull power management fixes from Rafael Wysocki:
 "These fix a recently exposed issue in the PCI device wakeup code and
  one older problem related to PCI device wakeup that has been reported
  recently, modify one more piece of computations in intel_pstate to get
  rid of a rounding error, fix a possible race in the schedutil cpufreq
  governor, fix the device PM QoS sysfs interface to correctly handle
  invalid user input, fix return values of two probe routines in devfreq
  drivers and constify an attribute_group structure in devfreq.

  Specifics:

   - Avoid clearing the PCI PME Enable bit for devices as a result of
     config space restoration which confuses AML executed afterward and
     causes wakeup events to be lost on some systems (Rafael Wysocki).

   - Fix the native PCIe PME interrupts handling in the cases when the
     PME IRQ is set up as a system wakeup one so that runtime PM remote
     wakeup works as expected after system resume on systems where that
     happens (Rafael Wysocki).

   - Fix the device PM QoS sysfs interface to handle invalid user input
     correctly instead of using an unititialized variable value as the
     latency tolerance for the device at hand (Dan Carpenter).

   - Get rid of one more rounding error from intel_pstate computations
     (Srinivas Pandruvada).

   - Fix the schedutil cpufreq governor to prevent it from possibly
     accessing unititialized data structures from governor callbacks in
     some cases on systems when multiple CPUs share a single cpufreq
     policy object (Vikram Mulukutla).

   - Fix the return values of probe routines in two devfreq drivers
     (Gustavo Silva).

   - Constify an attribute_group structure in devfreq (Arvind Yadav)"

* tag 'pm-fixes-4.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  PCI / PM: Fix native PME handling during system suspend/resume
  PCI / PM: Restore PME Enable after config space restoration
  cpufreq: schedutil: Fix sugov_start() versus sugov_update_shared() race
  PM / QoS: return -EINVAL for bogus strings
  cpufreq: intel_pstate: Fix ratio setting for min_perf_pct
  PM / devfreq: constify attribute_group structures.
  PM / devfreq: tegra: fix error return code in tegra_devfreq_probe()
  PM / devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe()

parents 867eacd7 6df609b2

drivers/base/power/sysfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -272,6 +272,8 @@ static ssize_t pm_qos_latency_tolerance_store(struct device *dev,
		value = PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT;
		else if (!strcmp(buf, "any") \|\| !strcmp(buf, "any\n"))
		value = PM_QOS_LATENCY_ANY;
		else
		return -EINVAL;
		}
		ret = dev_pm_qos_update_user_latency_tolerance(dev, value);
		return ret < 0 ? ret : n;

drivers/cpufreq/intel_pstate.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -572,7 +572,7 @@ static int min_perf_pct_min(void)
		int turbo_pstate = cpu->pstate.turbo_pstate;

		return turbo_pstate ?
		DIV_ROUND_UP(cpu->pstate.min_pstate * 100, turbo_pstate) : 0;
		(cpu->pstate.min_pstate * 100 / turbo_pstate) : 0;
		}

		static s16 intel_pstate_get_epb(struct cpudata *cpu_data)

drivers/devfreq/governor_userspace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ static struct attribute *dev_entries[] = {
		&dev_attr_set_freq.attr,
		NULL,
		};
		static struct attribute_group dev_attr_group = {
		static const struct attribute_group dev_attr_group = {
		.name = "userspace",
		.attrs = dev_entries,
		};

drivers/devfreq/rk3399_dmc.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
		return -EINVAL;
		dev_err(&pdev->dev,
		"Cannot get the dmc interrupt resource: %d\n", irq);
		return irq;
		}
		data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
		if (!data)

drivers/devfreq/tegra-devfreq.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
		}

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		dev_err(&pdev->dev, "Failed to get IRQ\n");
		return -ENODEV;
		if (irq < 0) {
		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
		return irq;
		}

		platform_set_drvdata(pdev, tegra);