Commit e27bcd66 authored Jan 28, 2017 by Lai Siyao Committed by Greg Kroah-Hartman Feb 03, 2017

staging: lustre: llite: normal user can't set FS default stripe



Current client doesn't check permission before updating filesystem
default stripe on MGS, which isn't secure and obvious.

Since we setattr on MDS first, and then set default stripe on MGS,
we can just return error upon setattr failure.

Now filesystem default stripe is stored in ROOT in MDT, so saving
it in system config is for compatibility with old servers, this
will be removed in the future.

Signed-off-by: Lai Siyao <lai.siyao@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8454
Reviewed-on: http://review.whamcloud.com/21612
Reviewed-on: http://review.whamcloud.com/22580


Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e39cb21b

drivers/staging/lustre/lustre/llite/dir.c

+9 −5

Original line number	Diff line number	Diff line
		@@ -521,12 +521,15 @@ int ll_dir_setstripe(struct inode inode, struct lov_user_md lump,
		rc = md_setattr(sbi->ll_md_exp, op_data, lump, lum_size, &req);
		ll_finish_md_op_data(op_data);
		ptlrpc_req_finished(req);
		if (rc) {
		if (rc != -EPERM && rc != -EACCES)
		CERROR("mdc_setattr fails: rc = %d\n", rc);
		}
		if (rc)
		return rc;

		/* In the following we use the fact that LOV_USER_MAGIC_V1 and
		#if OBD_OCD_VERSION(2, 13, 53, 0) > LUSTRE_VERSION_CODE
		/*
		* 2.9 server has stored filesystem default stripe in ROOT xattr,
		* and it's stored into system config for backward compatibility.
		*
		* In the following we use the fact that LOV_USER_MAGIC_V1 and
		* LOV_USER_MAGIC_V3 have the same initial fields so we do not
		* need to make the distinction between the 2 versions
		*/
		@@ -567,6 +570,7 @@ int ll_dir_setstripe(struct inode inode, struct lov_user_md lump,
		end:
		kfree(param);
		}
		#endif
		return rc;
		}