Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e208cda5 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Greg Kroah-Hartman
Browse files

netlink: Do not subscribe to non-existent groups 



[ Upstream commit 7acf9d4237c46894e0fa0492dd96314a41742e84 ]

Make ABI more strict about subscribing to group > ngroups.
Code doesn't check for that and it looks bogus.
(one can subscribe to non-existing group)
Still, it's possible to bind() to all possible groups with (-1)

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent da970765

net/netlink/af_netlink.c

+1 −0
Original line number Diff line number Diff line
@@ -976,6 +976,7 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr, 
		if (err)

			return err;

	}

	groups &= (1UL << nlk->ngroups) - 1;



	bound = nlk->bound;

	if (bound) {