Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e19493c1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

drivers/video/backlight/lm3630a_bl.c: potential NULL deref in probe() 



We dereference "pdata" later in the function so we can't leave it as NULL.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2a0c316b

drivers/video/backlight/lm3630a_bl.c

+12 −13
Original line number Diff line number Diff line
@@ -389,22 +389,21 @@ static int lm3630a_probe(struct i2c_client *client, 


	i2c_set_clientdata(client, pchip);

	if (pdata == NULL) {

		pchip->pdata = devm_kzalloc(pchip->dev,

					    sizeof(struct

						   lm3630a_platform_data),

		pdata = devm_kzalloc(pchip->dev,

				     sizeof(struct lm3630a_platform_data),

				     GFP_KERNEL);

		if (pchip->pdata == NULL)

		if (pdata == NULL)

			return -ENOMEM;

		/* default values */

		pchip->pdata->leda_ctrl = LM3630A_LEDA_ENABLE;

		pchip->pdata->ledb_ctrl = LM3630A_LEDB_ENABLE;

		pchip->pdata->leda_max_brt = LM3630A_MAX_BRIGHTNESS;

		pchip->pdata->ledb_max_brt = LM3630A_MAX_BRIGHTNESS;

		pchip->pdata->leda_init_brt = LM3630A_MAX_BRIGHTNESS;

		pchip->pdata->ledb_init_brt = LM3630A_MAX_BRIGHTNESS;

	} else {

		pchip->pdata = pdata;

		pdata->leda_ctrl = LM3630A_LEDA_ENABLE;

		pdata->ledb_ctrl = LM3630A_LEDB_ENABLE;

		pdata->leda_max_brt = LM3630A_MAX_BRIGHTNESS;

		pdata->ledb_max_brt = LM3630A_MAX_BRIGHTNESS;

		pdata->leda_init_brt = LM3630A_MAX_BRIGHTNESS;

		pdata->ledb_init_brt = LM3630A_MAX_BRIGHTNESS;

	}

	pchip->pdata = pdata;



	/* chip initialize */

	rval = lm3630a_chip_init(pchip);

	if (rval < 0) {