Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e167bfca authored by Hidetoshi Seto's avatar Hidetoshi Seto Committed by Jesse Barnes
Browse files

PCI: aerdrv: remove magical ROOT_ERR_STATUS_MASKS 



Make it clear that we only interest in 2 *_RCV bits.

Signed-off-by: default avatarHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: default avatarKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent f647a44f

drivers/pci/pcie/aer/aerdrv.c

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ irqreturn_t aer_irq(int irq, void *context) 


	/* Read error status */

	pci_read_config_dword(pdev->port, pos + PCI_ERR_ROOT_STATUS, &status);

	if (!(status & ROOT_ERR_STATUS_MASKS)) {

	if (!(status & (PCI_ERR_ROOT_UNCOR_RCV|PCI_ERR_ROOT_COR_RCV))) {

		spin_unlock_irqrestore(&rpc->e_lock, flags);

		return IRQ_NONE;

	}

drivers/pci/pcie/aer/aerdrv.h

+0 −3
Original line number Diff line number Diff line
@@ -17,9 +17,6 @@ 
#define AER_FATAL			1

#define AER_CORRECTABLE			2



/* Root Error Status Register Bits */

#define ROOT_ERR_STATUS_MASKS		0x0f



#define SYSTEM_ERROR_INTR_ON_MESG_MASK	(PCI_EXP_RTCTL_SECEE|	\

					PCI_EXP_RTCTL_SENFEE|	\

					PCI_EXP_RTCTL_SEFEE)