Commit e167a0b6 authored Jun 09, 2016 by Kedareswara rao Appana Committed by Vinod Koul Jun 13, 2016

dmaengine: vdma: Fix compilation warning in cyclic dma mode



This patch fixes the below compilation warining.
drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_dma_prep_dma_cyclic':
drivers/dma/xilinx/xilinx_vdma.c:1808:23: warning: 'segment' may be used
uninitialized in this function [-Wmaybe-uninitialized]
   segment->hw.control |= XILINX_DMA_BD_SOP;

The start of packet (SOP) should be set to the first segment in the desc
chain not for the last segment of the desc chain.

Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 62147866

drivers/dma/xilinx/xilinx_vdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1805,7 +1805,7 @@ static struct dma_async_tx_descriptor *xilinx_dma_prep_dma_cyclic(

		/* For the last DMA_MEM_TO_DEV transfer, set EOP */
		if (direction == DMA_MEM_TO_DEV) {
		segment->hw.control \|= XILINX_DMA_BD_SOP;
		head_segment->hw.control \|= XILINX_DMA_BD_SOP;
		segment = list_last_entry(&desc->segments,
		struct xilinx_axidma_tx_segment,
		node);