Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e04e3591 authored by Sujeev Dias's avatar Sujeev Dias Committed by Gerrit - the friendly Code Review server
Browse files

mhi: core: do not assert device wake when processing completion event 



When processing completion events, we do not need to assert
wake because device has already completed required work.

CRs-Fixed: 2248650
Change-Id: I0a1981baaae2784a23abf1fdc262bc9e7f2aa460
Signed-off-by: default avatarSujeev Dias <sdias@codeaurora.org>
parent 23154377

drivers/bus/mhi/core/mhi_main.c

+0 −6
Original line number Diff line number Diff line
@@ -880,17 +880,12 @@ int mhi_process_data_event_ring(struct mhi_controller *mhi_cntrl, 
	u32 chan;

	struct mhi_chan *mhi_chan;



	read_lock_bh(&mhi_cntrl->pm_lock);

	if (unlikely(MHI_EVENT_ACCESS_INVALID(mhi_cntrl->pm_state))) {

		MHI_ERR("No EV access, PM_STATE:%s\n",

			to_mhi_pm_state_str(mhi_cntrl->pm_state));

		read_unlock_bh(&mhi_cntrl->pm_lock);

		return -EIO;

	}



	mhi_cntrl->wake_get(mhi_cntrl, false);

	read_unlock_bh(&mhi_cntrl->pm_lock);



	dev_rp = mhi_to_virtual(ev_ring, er_ctxt->rp);

	local_rp = ev_ring->rp;
@@ -915,7 +910,6 @@ int mhi_process_data_event_ring(struct mhi_controller *mhi_cntrl, 
	read_lock_bh(&mhi_cntrl->pm_lock);

	if (likely(MHI_DB_ACCESS_VALID(mhi_cntrl->pm_state)))

		mhi_ring_er_db(mhi_event);

	mhi_cntrl->wake_put(mhi_cntrl, false);

	read_unlock_bh(&mhi_cntrl->pm_lock);



	MHI_VERB("exit er_index:%u\n", mhi_event->er_index);