Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ded82ef9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: comedi: usbdux: allocating too much data 



We only need to allocate enough space for a pointer.  We allocate the
space for the urbs themselves with the call to usb_alloc_urb() a few
lines later.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 253d50eb

drivers/staging/comedi/drivers/usbdux.c

+2 −2
Original line number Diff line number Diff line
@@ -1558,9 +1558,9 @@ static int usbdux_alloc_usb_buffers(struct comedi_device *dev) 
	devpriv->dux_commands = kzalloc(SIZEOFDUXBUFFER, GFP_KERNEL);

	devpriv->in_buf = kzalloc(SIZEINBUF, GFP_KERNEL);

	devpriv->insn_buf = kzalloc(SIZEINSNBUF, GFP_KERNEL);

	devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(*urb),

	devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(void *),

				   GFP_KERNEL);

	devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(*urb),

	devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(void *),

				   GFP_KERNEL);

	if (!devpriv->dux_commands || !devpriv->in_buf || !devpriv->insn_buf ||

	    !devpriv->ai_urbs || !devpriv->ao_urbs)