Commit de6cdcb5 authored May 23, 2016 by Muhammad Falak R Wani Committed by Linus Torvalds May 23, 2016

drivers/memstick/core/mspro_block: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated
region.  It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

[akpm@linux-foundation.org: remove unneeded cast to void*]
Link: http://lkml.kernel.org/r/1463665743-16269-1-git-send-email-falakreyaz@gmail.com


Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a831979f

drivers/memstick/core/mspro_block.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card)
		}
		msb->attr_group.name = "media_attributes";

		buffer = kmalloc(attr_len, GFP_KERNEL);
		buffer = kmemdup(attr, attr_len, GFP_KERNEL);
		if (!buffer) {
		rc = -ENOMEM;
		goto out_free_attr;
		}
		memcpy(buffer, (char *)attr, attr_len);

		for (cnt = 0; cnt < attr_count; ++cnt) {
		s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);