Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de33fb5e authored by Eliad Peller's avatar Eliad Peller Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: fix scan offloading flag definition 



Bit 0 in the scan offloading flags asks the filter
to pass all the results (instead of filtering them,
by default), rather than the other way around (like
it is defined and used today).

Fix the flag name appropriately, and fix its user.

Signed-off-by: default avatarEliad Peller <eliad@wizery.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 086f7368

drivers/net/wireless/iwlwifi/mvm/fw-api-scan.h

+2 −3
Original line number Diff line number Diff line
@@ -530,14 +530,13 @@ struct iwl_scan_offload_schedule { 
/*

 * iwl_scan_offload_flags

 *

 * IWL_SCAN_OFFLOAD_FLAG_FILTER_SSID: filter mode - upload every beacon or match

 *	ssid list.

 * IWL_SCAN_OFFLOAD_FLAG_PASS_ALL: pass all results - no filtering.

 * IWL_SCAN_OFFLOAD_FLAG_CACHED_CHANNEL: add cached channels to partial scan.

 * IWL_SCAN_OFFLOAD_FLAG_ENERGY_SCAN: use energy based scan before partial scan

 *	on A band.

 */

enum iwl_scan_offload_flags {

	IWL_SCAN_OFFLOAD_FLAG_FILTER_SSID	= BIT(0),

	IWL_SCAN_OFFLOAD_FLAG_PASS_ALL		= BIT(0),

	IWL_SCAN_OFFLOAD_FLAG_CACHED_CHANNEL	= BIT(2),

	IWL_SCAN_OFFLOAD_FLAG_ENERGY_SCAN	= BIT(3),

};

drivers/net/wireless/iwlwifi/mvm/scan.c

+1 −2
Original line number Diff line number Diff line
@@ -817,11 +817,10 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm *mvm, 
		IWL_DEBUG_SCAN(mvm,

			       "Sending scheduled scan with filtering, filter len %d\n",

			       req->n_match_sets);

		scan_req.flags |=

				cpu_to_le16(IWL_SCAN_OFFLOAD_FLAG_FILTER_SSID);

	} else {

		IWL_DEBUG_SCAN(mvm,

			       "Sending Scheduled scan without filtering\n");

		scan_req.flags |= cpu_to_le16(IWL_SCAN_OFFLOAD_FLAG_PASS_ALL);

	}



	return iwl_mvm_send_cmd_pdu(mvm, SCAN_OFFLOAD_REQUEST_CMD, CMD_SYNC,