Commit dde4afe7 authored Oct 24, 2015 by Julia Lawall Committed by Jacek Anaszewski Nov 03, 2015

powerpc/powernv: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent e9aadb86

drivers/leds/leds-powernv.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -262,15 +262,19 @@ static int powernv_led_classdev(struct platform_device *pdev,
		while ((cur = of_prop_next_string(p, cur)) != NULL) {
		powernv_led = devm_kzalloc(dev, sizeof(*powernv_led),
		GFP_KERNEL);
		if (!powernv_led)
		if (!powernv_led) {
		of_node_put(np);
		return -ENOMEM;
		}

		powernv_led->common = powernv_led_common;
		powernv_led->loc_code = (char *)np->name;

		rc = powernv_led_create(dev, powernv_led, cur);
		if (rc)
		if (rc) {
		of_node_put(np);
		return rc;
		}
		} /* while end */
		}