Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbb06ec2 authored by Patrick Daly's avatar Patrick Daly Committed by Liam Mark
Browse files

soc: qcom: secure_buffer: Fix memory leak 



Free the sg_table properly.

Change-Id: Idae945d17803e10756bf3a20426e57837d185067
Signed-off-by: default avatarPatrick Daly <pdaly@codeaurora.org>
parent 99bdc2d1

drivers/soc/qcom/secure_buffer.c

+7 −16
Original line number Diff line number Diff line
@@ -365,28 +365,19 @@ int hyp_assign_phys(phys_addr_t addr, u64 size, u32 *source_vm_list, 
			int source_nelems, int *dest_vmids,

			int *dest_perms, int dest_nelems)

{

	struct sg_table *table;

	struct sg_table table;

	int ret;



	table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);

	if (!table)

		return -ENOMEM;

	ret = sg_alloc_table(table, 1, GFP_KERNEL);

	ret = sg_alloc_table(&table, 1, GFP_KERNEL);

	if (ret)

		goto err1;

		return ret;



	sg_set_page(table->sgl, phys_to_page(addr), size, 0);

	sg_set_page(table.sgl, phys_to_page(addr), size, 0);



	ret = hyp_assign_table(table, source_vm_list, source_nelems, dest_vmids,

						dest_perms, dest_nelems);

	if (ret)

		goto err2;

	ret = hyp_assign_table(&table, source_vm_list, source_nelems,

			       dest_vmids, dest_perms, dest_nelems);



	return ret;

err2:

	sg_free_table(table);

err1:

	kfree(table);

	sg_free_table(&table);

	return ret;

}