Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db6fefb1 authored by Rajeev Kumar Sirasanagandla's avatar Rajeev Kumar Sirasanagandla Committed by nshrivas
Browse files

qcacld-3.0: Fix incorrect type and range for LFR ini 

Currently LFR band specific ini attributes 5g_rssi_boost_threshold
and 5g_rssi_penalize_threshold programmed with wrong type and range.
This can lead to ignore user-input and always use default value.

To fix this, correct min and max ini values for 5Ghz network RSSI
boost/penalty preference.

Change-Id: If89c09fb1343a68dfaa7241b5ec14b046d1bb758
CRs-Fixed: 2452128
parent c35c81aa

core/hdd/inc/wlan_hdd_cfg.h

+8 −8
Original line number Original line Diff line number Diff line
@@ -11019,8 +11019,8 @@ enum dot11p_mode { 
/*

/*

 * <ini>

 * <ini>

 * 5g_rssi_boost_threshold - A_band_boost_threshold above which 5 GHz is favored.

 * 5g_rssi_boost_threshold - A_band_boost_threshold above which 5 GHz is favored.

 * @Min: -55

 * @Min: -70

 * @Max: -70

 * @Max: -55

 * @Default: -60

 * @Default: -60

 * This ini is used to set threshold for 5GHz band preference.

 * This ini is used to set threshold for 5GHz band preference.

 *

 *
@@ -11034,8 +11034,8 @@ enum dot11p_mode { 
 * </ini>

 * </ini>

 */

 */

#define CFG_5G_RSSI_BOOST_THRESHOLD_NAME         "5g_rssi_boost_threshold"

#define CFG_5G_RSSI_BOOST_THRESHOLD_NAME         "5g_rssi_boost_threshold"

#define CFG_5G_RSSI_BOOST_THRESHOLD_MIN          (-55)

#define CFG_5G_RSSI_BOOST_THRESHOLD_MIN          (-70)

#define CFG_5G_RSSI_BOOST_THRESHOLD_MAX          (-70)

#define CFG_5G_RSSI_BOOST_THRESHOLD_MAX          (-55)

#define CFG_5G_RSSI_BOOST_THRESHOLD_DEFAULT      (-60)

#define CFG_5G_RSSI_BOOST_THRESHOLD_DEFAULT      (-60)





/*

/*
@@ -11086,8 +11086,8 @@ enum dot11p_mode { 
 * <ini>

 * <ini>

 * 5g_rssi_penalize_threshold - A_band_penalize_threshold above which

 * 5g_rssi_penalize_threshold - A_band_penalize_threshold above which

 * 5 GHz is not favored.

 * 5 GHz is not favored.

 * @Min: -65

 * @Min: -80

 * @Max: -80

 * @Max: -65

 * @Default: -70

 * @Default: -70

 * This ini is used to set threshold for 5GHz band preference.

 * This ini is used to set threshold for 5GHz band preference.

 *

 *
@@ -11101,8 +11101,8 @@ enum dot11p_mode { 
 * </ini>

 * </ini>

 */

 */

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_NAME      "5g_rssi_penalize_threshold"

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_NAME      "5g_rssi_penalize_threshold"

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_MIN       (-65)

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_MIN       (-80)

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_MAX       (-80)

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_MAX       (-65)

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_DEFAULT   (-70)

#define CFG_5G_RSSI_PENALIZE_THRESHOLD_DEFAULT   (-70)





/*

/*

core/hdd/src/wlan_hdd_cfg.c

+8 −7
Original line number Original line Diff line number Diff line
@@ -4962,7 +4962,7 @@ struct reg_table_entry g_registry_table[] = { 
		CFG_ENABLE_5G_BAND_PREF_MIN,

		CFG_ENABLE_5G_BAND_PREF_MIN,

		CFG_ENABLE_5G_BAND_PREF_MAX),

		CFG_ENABLE_5G_BAND_PREF_MAX),





	REG_VARIABLE(CFG_5G_RSSI_BOOST_THRESHOLD_NAME, WLAN_PARAM_Integer,

	REG_VARIABLE(CFG_5G_RSSI_BOOST_THRESHOLD_NAME, WLAN_PARAM_SignedInteger,

		struct hdd_config, rssi_boost_threshold_5g,

		struct hdd_config, rssi_boost_threshold_5g,

		VAR_FLAGS_OPTIONAL | VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT,

		VAR_FLAGS_OPTIONAL | VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT,

		CFG_5G_RSSI_BOOST_THRESHOLD_DEFAULT,

		CFG_5G_RSSI_BOOST_THRESHOLD_DEFAULT,
@@ -4983,7 +4983,8 @@ struct reg_table_entry g_registry_table[] = { 
		CFG_5G_MAX_RSSI_BOOST_MIN,

		CFG_5G_MAX_RSSI_BOOST_MIN,

		CFG_5G_MAX_RSSI_BOOST_MAX),

		CFG_5G_MAX_RSSI_BOOST_MAX),





	REG_VARIABLE(CFG_5G_RSSI_PENALIZE_THRESHOLD_NAME, WLAN_PARAM_Integer,

	REG_VARIABLE(CFG_5G_RSSI_PENALIZE_THRESHOLD_NAME,

		     WLAN_PARAM_SignedInteger,

		     struct hdd_config, rssi_penalize_threshold_5g,

		     struct hdd_config, rssi_penalize_threshold_5g,

		     VAR_FLAGS_OPTIONAL | VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT,

		     VAR_FLAGS_OPTIONAL | VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT,

		     CFG_5G_RSSI_PENALIZE_THRESHOLD_DEFAULT,

		     CFG_5G_RSSI_PENALIZE_THRESHOLD_DEFAULT,