Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db6321a1 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mauro Carvalho Chehab
Browse files

media: platform: VIDEO_QCOM_CAMSS should depend on HAS_DMA 



If NO_DMA=y:

    warning: (TOUCHSCREEN_SUR40 && VIDEO_TW68 && VIDEO_CX23885 && VIDEO_CX25821 && VIDEO_CX88 && VIDEO_SAA7134 && VIDEO_COBALT && VIDEO_QCOM_CAMSS) selects VIDEOBUF2_DMA_SG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)

and

    ERROR: "bad_dma_ops" [drivers/media/v4l2-core/videobuf2-dma-sg.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/media/platform/qcom/camss-8x16/qcom-camss.ko] undefined!

VIDEO_QCOM_CAMSS selects VIDEOBUF2_DMA_SG, which bypasses its dependency
on HAS_DMA.  Make VIDEO_QCOM_CAMSS depend on HAS_DMA to fix this.

Fixes: f5c07494 ("media: camss: Enable building")

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
parent 845d6524

drivers/media/platform/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ config VIDEO_PXA27x 


config VIDEO_QCOM_CAMSS

	tristate "Qualcomm 8x16 V4L2 Camera Subsystem driver"

	depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API

	depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA

	depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST

	select VIDEOBUF2_DMA_SG

	select V4L2_FWNODE