Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db6172c4 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Al Viro
Browse files

fs: cleanup slight list_entry abuse 



list_entry is just a wrapper for container_of, but it is arguably
wrong (and slightly confusing) to use it when the pointed-to struct
member is not a struct list_head. Use container_of directly instead.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 8ea3a7c0

fs/affs/affs.h

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ struct affs_inode_info { 
/* short cut to get to the affs specific inode data */

static inline struct affs_inode_info *AFFS_I(struct inode *inode)

{

	return list_entry(inode, struct affs_inode_info, vfs_inode);

	return container_of(inode, struct affs_inode_info, vfs_inode);

}



/*

fs/befs/befs.h

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ BEFS_SB(const struct super_block *super) 
static inline struct befs_inode_info *

BEFS_I(const struct inode *inode)

{

	return list_entry(inode, struct befs_inode_info, vfs_inode);

	return container_of(inode, struct befs_inode_info, vfs_inode);

}



static inline befs_blocknr_t

fs/coda/coda_linux.h

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ void coda_sysctl_clean(void); 


static inline struct coda_inode_info *ITOC(struct inode *inode)

{

	return list_entry(inode, struct coda_inode_info, vfs_inode);

	return container_of(inode, struct coda_inode_info, vfs_inode);

}



static __inline__ struct CodaFid *coda_i2f(struct inode *inode)

fs/hfs/hfs_fs.h

+1 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ extern void hfs_mark_mdb_dirty(struct super_block *sb); 
#define __hfs_u_to_mtime(sec)	cpu_to_be32(sec + 2082844800U - sys_tz.tz_minuteswest * 60)

#define __hfs_m_to_utime(sec)	(be32_to_cpu(sec) - 2082844800U  + sys_tz.tz_minuteswest * 60)



#define HFS_I(inode)	(list_entry(inode, struct hfs_inode_info, vfs_inode))

#define HFS_I(inode)	(container_of(inode, struct hfs_inode_info, vfs_inode))

#define HFS_SB(sb)	((struct hfs_sb_info *)(sb)->s_fs_info)



#define hfs_m_to_utime(time)	(struct timespec){ .tv_sec = __hfs_m_to_utime(time) }

fs/hfsplus/hfsplus_fs.h

+1 −1
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ struct hfsplus_inode_info { 


static inline struct hfsplus_inode_info *HFSPLUS_I(struct inode *inode)

{

	return list_entry(inode, struct hfsplus_inode_info, vfs_inode);

	return container_of(inode, struct hfsplus_inode_info, vfs_inode);

}



/*