Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9bba4c3 authored by Russell King's avatar Russell King Committed by Herbert Xu
Browse files

crypto: marvell/cesa - use presence of scatterlist to determine data load 



Use the presence of the scatterlist to determine whether we should load
any new user data to the engine.  The following shall always be true at
this point:

	iter.base.op_len == 0 === iter.src.sg

In doing so, we can:

1. eliminate the test for iter.base.op_len inside the loop, which
   makes the loop operation more obvious and understandable.

2. move the operation generation for the cache-only case.

This prepares the code for the next step in its transformation, and also
uncovers a bug that will be fixed in the next patch.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0971d09a

drivers/crypto/marvell/hash.c

+21 −18
Original line number Diff line number Diff line
@@ -627,19 +627,13 @@ static int mv_cesa_ahash_dma_req_init(struct ahash_request *req) 
	if (ret)

		goto err_free_tdma;



	if (creq->cache_ptr && !iter.base.op_len) {

		op = mv_cesa_dma_add_frag(&chain, &creq->op_tmpl,

					  creq->cache_ptr, flags);

		if (IS_ERR(op)) {

			ret = PTR_ERR(op);

			goto err_free_tdma;

		}

	}



	if (iter.src.sg) {

		/*

		 * Add all the new data, inserting an operation block and

		 * launch command between each full SRAM block-worth of

		 * data.

		 */

		do {

		if (!iter.base.op_len)

			break;



			ret = mv_cesa_dma_add_op_transfers(&chain, &iter.base,

							   &iter.src, flags);

			if (ret)
@@ -652,6 +646,15 @@ static int mv_cesa_ahash_dma_req_init(struct ahash_request *req) 
				goto err_free_tdma;

			}

		} while (mv_cesa_ahash_req_iter_next_op(&iter));

	} else if (creq->cache_ptr) {

		/* Account for the data that was in the cache. */

		op = mv_cesa_dma_add_frag(&chain, &creq->op_tmpl,

					  creq->cache_ptr, flags);

		if (IS_ERR(op)) {

			ret = PTR_ERR(op);

			goto err_free_tdma;

		}

	}



	op = mv_cesa_ahash_dma_last_req(&chain, &iter, creq, op, flags);

	if (IS_ERR(op)) {