Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d81931d9 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Linus Torvalds
Browse files

[PATCH] SKB leak in drivers/isdn/i4l/isdn_x25iface.c 



Coverity spotted this leak (id #613), when we are not configured, we return
without freeing the allocated skb.

Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Acked-by: default avatarKarsten Keil <kkeil@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9dc3885d

drivers/isdn/i4l/isdn_x25iface.c

+3 −1
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ static int isdn_x25iface_receive(struct concap_proto *cprot, struct sk_buff *skb 
 */

static int isdn_x25iface_connect_ind(struct concap_proto *cprot)

{

	struct sk_buff * skb = dev_alloc_skb(1);

	struct sk_buff * skb;

	enum wan_states *state_p 

	  = &( ( (ix25_pdata_t*) (cprot->proto_data) ) -> state);

	IX25DEBUG( "isdn_x25iface_connect_ind %s \n"
@@ -220,6 +220,8 @@ static int isdn_x25iface_connect_ind(struct concap_proto *cprot) 
		return -1;

	}

	*state_p = WAN_CONNECTED;



	skb = dev_alloc_skb(1);

	if( skb ){

		*( skb_put(skb, 1) ) = 0x01;

		skb->protocol = x25_type_trans(skb, cprot->net_dev);