Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d81638ea authored by Frank Schaefer's avatar Frank Schaefer Committed by Mauro Carvalho Chehab
Browse files

[media] ov2640: improve banding filter register definitions/documentation 



- add missing initialisation of sensor register COM25 (2 MSBs of banding
  filter AEC values)
- add macros for setting the banding filter AEC values
- add definitions for sensor register 0x5a, which is documented in
  Omnivisions software application notes

Signed-off-by: default avatarFrank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 534dca98

drivers/media/i2c/ov2640.c

+17 −3
Original line number Diff line number Diff line
@@ -248,8 +248,19 @@ 
#define ZOOMS       0x49 /* Zoom: Vertical start point */

#define COM22       0x4B /* Flash light control */

#define COM25       0x4E /* For Banding operations */

#define   COM25_50HZ_BANDING_AEC_MSBS_MASK      0xC0 /* 50Hz Bd. AEC 2 MSBs */

#define   COM25_60HZ_BANDING_AEC_MSBS_MASK      0x30 /* 60Hz Bd. AEC 2 MSBs */

#define   COM25_50HZ_BANDING_AEC_MSBS_SET(x)    VAL_SET(x, 0x3, 8, 6)

#define   COM25_60HZ_BANDING_AEC_MSBS_SET(x)    VAL_SET(x, 0x3, 8, 4)

#define BD50        0x4F /* 50Hz Banding AEC 8 LSBs */

#define   BD50_50HZ_BANDING_AEC_LSBS_SET(x)     VAL_SET(x, 0xFF, 0, 0)

#define BD60        0x50 /* 60Hz Banding AEC 8 LSBs */

#define   BD60_60HZ_BANDING_AEC_LSBS_SET(x)     VAL_SET(x, 0xFF, 0, 0)

#define REG5A       0x5A /* 50/60Hz Banding Maximum AEC Step */

#define   BD50_MAX_AEC_STEP_MASK         0xF0 /* 50Hz Banding Max. AEC Step */

#define   BD60_MAX_AEC_STEP_MASK         0x0F /* 60Hz Banding Max. AEC Step */

#define   BD50_MAX_AEC_STEP_SET(x)       VAL_SET((x - 1), 0x0F, 0, 4)

#define   BD60_MAX_AEC_STEP_SET(x)       VAL_SET((x - 1), 0x0F, 0, 0)

#define REG5D       0x5D /* AVGsel[7:0],   16-zone average weight option */

#define REG5E       0x5E /* AVGsel[15:8],  16-zone average weight option */

#define REG5F       0x5F /* AVGsel[23:16], 16-zone average weight option */
@@ -356,9 +367,12 @@ static const struct regval_list ov2640_init_regs[] = { 
	{ 0x73,   0xc1 },

	{ 0x3d,   0x34 },

	{ COM7,   COM7_RES_UXGA | COM7_ZOOM_EN },

	{ 0x5a,   0x57 },

	{ BD50,   0xbb },

	{ BD60,   0x9c },

	{ REG5A,  BD50_MAX_AEC_STEP_SET(6)

		   | BD60_MAX_AEC_STEP_SET(8) },		/* 0x57 */

	{ COM25,  COM25_50HZ_BANDING_AEC_MSBS_SET(0x0bb)

		   | COM25_60HZ_BANDING_AEC_MSBS_SET(0x09c) },	/* 0x00 */

	{ BD50,   BD50_50HZ_BANDING_AEC_LSBS_SET(0x0bb) },	/* 0xbb */

	{ BD60,   BD60_60HZ_BANDING_AEC_LSBS_SET(0x09c) },	/* 0x9c */

	{ BANK_SEL,  BANK_SEL_DSP },

	{ 0xe5,   0x7f },

	{ MC_BIST,  MC_BIST_RESET | MC_BIST_BOOT_ROM_SEL },