Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d762ad47 authored by Felipe Balbi's avatar Felipe Balbi Committed by Greg Kroah-Hartman
Browse files

usb: storagE: realtek_cr: fix sparse warnings



Fix the following sparse warnings:

| drivers/usb/storage/realtek_cr.c:821:6: warning: symbol
|	'rts51x_invoke_transport' was not declared. Should
|	it be static?
|
| drivers/usb/storage/realtek_cr.c:980:5: warning: symbol
|	'realtek_cr_suspend' was not declared. Should it
|	be static?
|
| drivers/usb/storage/realtek_cr.c:518:23: warning: cast
|	truncates bits from constant value (fe47 becomes 47)

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e2c83f01
Loading
Loading
Loading
Loading
+5 −6
Original line number Diff line number Diff line
@@ -507,15 +507,14 @@ static int enable_oscillator(struct us_data *us)
static int __do_config_autodelink(struct us_data *us, u8 *data, u16 len)
{
	int retval;
	u16 addr = 0xFE47;
	u8 cmnd[12] = {0};

	US_DEBUGP("%s, addr = 0x%x, len = %d\n", __FUNCTION__, addr, len);
	US_DEBUGP("%s, addr = 0xfe47, len = %d\n", __FUNCTION__, len);

	cmnd[0] = 0xF0;
	cmnd[1] = 0x0E;
	cmnd[2] = (u8)(addr >> 8);
	cmnd[3] = (u8)addr;
	cmnd[2] = 0xfe;
	cmnd[3] = 0x47;
	cmnd[4] = (u8)(len >> 8);
	cmnd[5] = (u8)len;

@@ -818,7 +817,7 @@ static inline int working_scsi(struct scsi_cmnd *srb)
	return 1;
}

void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
{
	struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra);
	static int card_first_show = 1;
@@ -977,7 +976,7 @@ static void realtek_cr_destructor(void *extra)
}

#ifdef CONFIG_PM
int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
static int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
{
	struct us_data *us = usb_get_intfdata(iface);